Poggu and others debug another bug: splash sound while shifting in water

Im copying the whole post here because Twitter forces you to make an account now:

We debugged another game breaking bug. Sometimes you'd get in a state where shifting in water would still play footsteps.

This happens whenever your ragdoll FALLS in water, meaning you have to die on ground and your ragdoll falls into the water, not you dying directly in water.

The game is trying to be fancy and add splashing effects to several bones of a ragdoll when a ragdoll touches func_water, however they do this by spawning a water_splasher entity for each bone and parenting/attaching it to it, this entity NEVER gets deleted.

Thus when you respawn you still have all the splasher entities on you and whenever they touch water they splash, and these splasher don't care if you are walking or not, they are not supposed to exist on living players.

Thanks to @sileeeent for finding a reproducible way to do this in an offline match allowing me to debug this.